upcoming: [M3-8074] – Add "Disk Encryption" section to Linode Create flow

[dwiley-akamai]

Description 📝

Add "Disk Encryption" section to the Linode Create flow to allow user to choose if their VM will be encrypted or not.

Changes 🔄

• Disk Encryption added as AccountCapability and region Capabilities
• New props added to AccessPanel component
• Conditional notice for Backups added in AddonsPanel component
• useIsDiskEncryptionFeatureEnabled hook added

Target release date 🗓️

5/28/24

Preview 📷

Before (LDE not supported)	After (LDE supported)

How to test 🧪

Prerequisites

1. Have the linode_disk_encryption tag on your account
2. Point at the alpha/dev environment
3. Have the Linode Disk Encryption (LDE) flag in our dev tool toggled on

Verification steps

Without the customer tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI (or in the Linode Create payload). Otherwise,

1. "Disk Encryption" should be below "SSH Keys" in the same paper, and that paper should be labeled "Security"
   a. No region selected or region w/o Disk Encryption support selected --> "Encrypt Disk" checkbox should be unchecked and disabled with an explanatory tooltip; region w/ Disk Encryption support selected (Newark has support in alpha) --> checkbox should be enabled, and default to checked
   b. Toggling the "Encrypt Disk" checkbox should work as expected
   c. The "Summary" section at the bottom should reflect your choice to encrypt or not, i.e., if "Encrypt Disk" is checked, you should see "Encrypted" in the summary
   d. "Encrypt Disk" checked & Backups add-on checked --> observe: notice under Backups stating, "Virtual Machine Backups are not encrypted."
2. disk_encryption shows with the expected value for cURL and Linode CLI when you click "Create Using Command Line" (and should be absent when the selected region doesn't support LDE)
3. No adverse or unexpected impacts where <AccessPanel /> is used elsewhere (e.g., UDF fields, Rebuild from Image & Stackscript, Create Disk drawer --> Create from Image, etc.)

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[bnussman-akamai]

I'm not sure how I feel about putting disk encryption in the Access Panel on the Linode create flow. Disk encryption feels unrelated to configuring credentials to me.

I think the Addons section would be a lot more fitting. (and maybe rename addons to "Options" or "Additional Configuration" if UX is concerned about the "Addons" naming)

[dwiley-akamai]

I'm not sure how I feel about putting disk encryption in the Access Panel on the Linode create flow. Disk encryption feels unrelated to configuring credentials to me.

I think the Addons section would be a lot more fitting. (and maybe rename addons to "Options" or "Additional Configuration" if UX is concerned about the "Addons" naming)

I surfaced this feedback to UX and Product, and the consensus was to roll forward with the current UX given encryption's centrality to the VM creation workflow

[bnussman-akamai]

Got it! Thanks for surfacing 👍🙏🏼

[github-actions]

Coverage Report: ✅
Base Coverage: 81.53%
Current Coverage: 81.6%

[jaalah-akamai]

✅ Encryption works based on regions
✅ Encryption shows in summary
✅ Encryption enabled shows in payload and request
✅ Add-on notice appears as expected

[carrillo-erik]

I wonder if it would be worth it to rename the AccessPanel component to SecurityPanel or maybe change the header of the AccessPanel to reflect the name of the component. It appears this is the only panel whose header does not match the component name in the code.

Aside from comment above, I was able to verify all functionality described in the "Verification Steps" to work as intended. LGTM ✅

[dwiley-akamai]

I wonder if it would be worth it to rename the AccessPanel component to SecurityPanel or maybe change the header of the AccessPanel to reflect the name of the component. It appears this is the only panel whose header does not match the component name in the code.

That file probably won't be around more than a couple of months given the Linode Create v2 effort so I'd say it's not worth it, but I will keep a possible renaming in mind for the equivalent v2 file (src/features/Linodes/LinodeCreatev2/Access.tsx)

edit: it may be around since it does get used in other places, but not all of them will have the "Security" header