Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[M3-8090] - Remove regions field from OBJ Accesskey Payload #10453

Closed
wants to merge 1 commit into from

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented May 9, 2024

Description πŸ“

Highlight the Pull Request's context and intentions.

Changes πŸ”„

List any change relevant to the reviewer.

  • ...
  • ...

Target release date πŸ—“οΈ

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview πŸ“·

Payload with Flag off Payload with Flag on
image image

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner May 9, 2024 16:53
@cpathipa cpathipa requested review from jdamore-linode and abailly-akamai and removed request for a team May 9, 2024 16:53
@cpathipa cpathipa marked this pull request as draft May 9, 2024 16:53
@cpathipa cpathipa self-assigned this May 9, 2024
@@ -18,7 +18,7 @@ export type AccessType = 'read_only' | 'read_write' | 'none';
export interface Scope {
bucket_name: string;
permissions: AccessType;
cluster: string;
cluster?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this warrants the same conversation about weakening types because of feature update. Let's see what comes out of it when we get around the topic

@cpathipa
Copy link
Contributor Author

cpathipa commented Jun 3, 2024

Closing this PR since it is not needed.

@cpathipa cpathipa closed this Jun 3, 2024
@cpathipa cpathipa deleted the M3-8090-fix-remove-regions branch June 3, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants