refactor: [M3-8071] - Rename Edge Regions to Distributed Regions #10452

jaalah-akamai · 2024-05-09T16:50:52Z

Description 📝

Effort to bring clarity to new regions and plan offerings

Changes 🔄

Important: For our types and places we're checking for site_type, we're allowing both edge and distributed until the DB/API changes are ready. Then we'll do some cleanup afterwards.
Everywhere we used the term edge will now be called distributed.
In places where we only used the name/text edge, I've included region for clarity.
- Example: type SupportedEdgeTypes => type SupportedDistributedRegionTypes

Target release date 🗓️

TBD: We will try to release this in conjunction with API changes

Preview 📷

Before	After

How to test 🧪

Prerequisites

Pull down branch and ensure Gecko feature flag is active in dev tools

Reproduction steps

Try to create a Linode in an edge/distributed region
Observe edge should no longer be shown
Using MSW, try to migrate an edge/distributed linode to a non-distributed region
Observe warnings should be updated

As an Author I have considered 🤔

Check all that apply

github-actions · 2024-05-09T17:24:22Z

Coverage Report: ✅
Base Coverage: 82.35%
Current Coverage: 82.35%

jaalah-akamai · 2024-05-13T13:23:19Z

packages/manager/src/components/RegionSelect/RegionSelect.styles.ts

+    alignSelf: 'start',
+    marginLeft: 0,
+  },
+}));


No changes in the styles, just the name

jaalah-akamai · 2024-05-13T13:41:23Z

packages/manager/src/features/components/PlansPanel/DistributedRegionPlanTable.tsx

+const StyledTypography = styled(Typography)(({ theme }) => ({
+  fontSize: '0.875rem',
+  marginTop: theme.spacing(1),
+}));


This file only contains a name change from EdgePlanTable to DistributedRegionPlanTable

dwiley-akamai

"Edge" --> "Distributed" in Linode Create flow ✅
"Edge" --> "Distributed" in Linode Migrate modal ✅

packages/manager/src/components/RegionSelect/RegionSelect.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

hana-linode

Left some minor spelling feedback

I'm not seeing the edge regions populated for the new region input in the migrate dialog 🤔

packages/manager/src/components/RegionSelect/RegionOption.tsx

packages/manager/src/components/RegionSelect/RegionSelect.tsx

packages/manager/src/components/RegionSelect/RegionSelect.utils.tsx

packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/BackupsPlaceholder.tsx

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/AddIPDrawer.tsx

packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.test.tsx

packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.tsx

packages/manager/src/features/Linodes/MigrateLinode/ConfigureForm.tsx

Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…s.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…up/BackupsPlaceholder.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…orking/AddIPDrawer.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…ilities.test.ts Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…l.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…ent/FromBackupsContent.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

…ent/FromLinodeContent.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

hana-linode · 2024-05-15T13:55:02Z

packages/api-v4/src/linodes/types.ts

@@ -333,7 +333,8 @@ export type LinodeTypeClass =
  | 'metal'
  | 'prodedicated'
  | 'premium'
-  | 'edge';
+  | 'edge'
+  | 'distributed';


Seems like the class is going to be dedicated

Agreed, we can remove distributed now (Left comment below)

jaalah-akamai · 2024-05-15T16:10:39Z

packages/manager/src/features/components/PlansPanel/PlansPanel.tsx

+      (type) =>
+        type.id.includes('dedicated-edge') ||
+        type.id.includes('nanode-edge') ||
+        type.class === 'edge'
    );


Since the SLUGs are changing we can't rely on the class to determine if the plan type is included in the distributed region. The API used to look at the second element of the SLUG to determine the class: IE: g6-dedicated-nanode would equal class: edge. The slug's are now being returned g6-dedicated-edge (the positions are swapped), so now we need to look at the id to determine this.

dwiley-akamai

The renamings look consistent throughout the UI and codebase ✅

mjac0bs

Tests are passing and all the replacements of edge -> distributed looked good where they're not being returned from API. There's a conflict to resolve before merging, but then 🚀 .

jaalah added 2 commits May 9, 2024 12:30

refactor: [M3-8071] - Rename Edge Regions to Distributed Regions

aa772a5

Update component name for DistributedPlanTable

123e8fa

jaalah-akamai added Work in Progress Do Not Merge Gecko GA Relating to Gecko GA labels May 9, 2024

jaalah-akamai self-assigned this May 9, 2024

jaalah-akamai requested a review from a team as a code owner May 9, 2024 16:50

jaalah-akamai requested review from dwiley-akamai and cpathipa and removed request for a team May 9, 2024 16:50

Fix merge conflict from latest

553aa74

jaalah-akamai added Gecko Beta Relating to Gecko project and removed Gecko GA Relating to Gecko GA labels May 9, 2024

jaalah added 2 commits May 13, 2024 09:20

We'll need both distributed / edge for one release

cce285a

Update places where we need to maintain 'edge'

3a7b6cf

jaalah-akamai commented May 13, 2024

View reviewed changes

jaalah-akamai requested a review from hana-linode May 13, 2024 13:48

jaalah-akamai assigned hana-linode May 13, 2024

Remove edge/distributed from slug in mocks

b8dfe0b

jaalah-akamai removed the Work in Progress label May 13, 2024

dwiley-akamai reviewed May 13, 2024

View reviewed changes

packages/manager/src/components/RegionSelect/RegionSelect.tsx Outdated Show resolved Hide resolved

Update packages/manager/src/components/RegionSelect/RegionSelect.tsx

4787c80

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

hana-linode reviewed May 13, 2024

View reviewed changes

jaalah-akamai and others added 6 commits May 15, 2024 09:17

Update packages/manager/src/components/RegionSelect/RegionOption.tsx

c52dbf2

Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/components/RegionSelect/RegionSelect.tsx

b5e35cb

Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/components/RegionSelect/RegionSelect.util…

95ed90d

…s.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/components/RegionSelect/RegionSelect.util…

98a0faf

…s.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/features/Linodes/LinodesDetail/LinodeBack…

b3ef256

…up/BackupsPlaceholder.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/features/Linodes/LinodesDetail/LinodeNetw…

be7fb11

…orking/AddIPDrawer.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

jaalah-akamai and others added 5 commits May 15, 2024 09:21

Update packages/manager/src/features/Linodes/LinodeCreatev2/Addons/ut…

04aa80f

…ilities.test.ts Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/features/Linodes/LinodesCreate/AddonsPane…

5648378

…l.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/features/Linodes/LinodesCreate/TabbedCont…

a58a4c9

…ent/FromBackupsContent.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Update packages/manager/src/features/Linodes/LinodesCreate/TabbedCont…

cbdc3db

…ent/FromLinodeContent.tsx Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>

Use getIsDistributedRegion for create image tab

2844828

hana-linode reviewed May 15, 2024

View reviewed changes

Revert distributed class since it will become dedicated

b08ebd0

jaalah-akamai commented May 15, 2024

View reviewed changes

Merge branch 'develop' of github.com:linode/manager into M3-8071

cc6135b

hana-linode added the Work in Progress label May 16, 2024

jcallahan-akamai removed the request for review from cpathipa May 21, 2024 15:04

Merge branch 'develop' into M3-8071

06cef3f

hana-linode force-pushed the M3-8071 branch from e6b5e95 to 06cef3f Compare May 31, 2024 15:20

hana-linode requested a review from a team as a code owner May 31, 2024 15:20

hana-linode requested review from cliu-akamai and removed request for a team May 31, 2024 15:20

hana-linode added 2 commits May 31, 2024 11:50

spelling

a798514

clean up

fb51e32

hana-linode removed the Work in Progress label May 31, 2024

hana-linode approved these changes May 31, 2024

View reviewed changes

Merge branch 'develop' into M3-8071

0a50113

hana-linode requested a review from dwiley-akamai May 31, 2024 16:11

hana-linode added the Add'tl Approval Needed Waiting on another approval! label May 31, 2024

dwiley-akamai approved these changes Jun 3, 2024

View reviewed changes

mjac0bs approved these changes Jun 4, 2024

View reviewed changes

mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 4, 2024

Merge branch 'develop' into M3-8071

2da3da5

hana-linode removed the Do Not Merge label Jun 4, 2024

hana-linode merged commit bbbca9b into linode:develop Jun 4, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: [M3-8071] - Rename Edge Regions to Distributed Regions #10452

refactor: [M3-8071] - Rename Edge Regions to Distributed Regions #10452

jaalah-akamai commented May 9, 2024 •

edited by dwiley-akamai

github-actions bot commented May 9, 2024 •

edited

jaalah-akamai May 13, 2024

jaalah-akamai May 13, 2024

dwiley-akamai left a comment

hana-linode left a comment

hana-linode May 15, 2024

jaalah-akamai May 15, 2024

jaalah-akamai May 15, 2024 •

edited

dwiley-akamai left a comment

mjac0bs left a comment

refactor: [M3-8071] - Rename Edge Regions to Distributed Regions #10452

refactor: [M3-8071] - Rename Edge Regions to Distributed Regions #10452

Conversation

jaalah-akamai commented May 9, 2024 • edited by dwiley-akamai

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

As an Author I have considered 🤔

github-actions bot commented May 9, 2024 • edited

jaalah-akamai May 13, 2024

Choose a reason for hiding this comment

jaalah-akamai May 13, 2024

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

hana-linode left a comment

Choose a reason for hiding this comment

hana-linode May 15, 2024

Choose a reason for hiding this comment

jaalah-akamai May 15, 2024

Choose a reason for hiding this comment

jaalah-akamai May 15, 2024 • edited

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

jaalah-akamai commented May 9, 2024 •

edited by dwiley-akamai

github-actions bot commented May 9, 2024 •

edited

jaalah-akamai May 15, 2024 •

edited