feat: [LKEAPIFW-258] - Enabling LKE events in CM #10443
Conversation
talmai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
talmai
force-pushed
the
feature/lkeapifw-258-apinext-lke-events
branch
2 times, most recently
from
4a6c6e8
to
71065cd
Compare
|
Coverage Report: ❌ |
talmai
force-pushed
the
feature/lkeapifw-258-apinext-lke-events
branch
2 times, most recently
from
097ad93
to
4efa8dd
Compare
bnussman-akamai
changed the title
bnussman-akamai
changed the title
| @@ -616,6 +616,62 @@ export const eventMessageCreators: { [index: string]: CreatorsForStatus } = { | |||
| e.entity?.label ? ` ${e.entity.label}` : '' | |||
| }.`, | |||
| }, | |||
| lke_node_recycle: { | |||
| notification: (e) => | |||
| `The node for Kubernetes Cluster ${e.entity!.label} has been recycled.`, | |||
There was a problem hiding this comment.
Can we use optional chaining with default values instead of a null assertion?
example: e.entity?.label ?? '' We could follow the same approach in other places as well.
talmai
force-pushed
the
feature/lkeapifw-258-apinext-lke-events
branch
from
53cffb5
to
98bf6ba
Compare
updated with optional chaining instead of null assertion
talmai
force-pushed
the
feature/lkeapifw-258-apinext-lke-events
branch
from
cdb0a5c
to
ed6201e
Compare
| e.entity?.label ? ` ${e.entity.label}` : '' | ||
| } has been created.`, | ||
| }, | ||
| lke_pool_recyle: { |
There was a problem hiding this comment.
Typo
| lke_pool_recyle: { | |
| lke_pool_recycle: { |
There was a problem hiding this comment.
Thanks @talmai! I think you'll need to also update our API library's EventAction type to include these new LKE event actions:
https://github.com/linode/manager/blob/develop/packages/api-v4/src/account/types.ts#L280
Other than that, this is looking great!
There was a problem hiding this comment.
Thanks again @talmai!
(Just to follow up from our discussion, here's a quick screenshot of the commands/output used to generate the changeset files -- then I just committed and pushed the files generated by the command 👍)
Description 📝
Enables LKE events (from apinext) to become highlighted as valid events on CM.
Changes 🔄
Added new messages
Target release date 🗓️
Not sure of which goes first, but this is related to these nimbus/apinext PRs.
Preview 📷
How to test 🧪
Spin up a dev CPC and wire everything in devenv. You will need to pull my apinext/nimbus as well. Since this relies on custom apinext code, you can't just wire it up to alpha. Once wired in though, execute actions related to LKE clusters.
Prerequisites
See how to test
Verification steps
See how to test
As an Author I have considered 🤔
Check all that apply