feat(completion): add zsh support #609
Open
+93
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
|
You should be able to convert the bash completions using |
|
@chenrui333 I think we're planning on cutting a patch to get only #608 out given this PR will need a bit more vetting/testing. Will that work for you? |
|
yeah, that works for me. |
| command_template = Template( | ||
| """$command) | ||
| command=( | ||
| '$actions --help' |
There was a problem hiding this comment.
I'm seeing some weird outputs attempting to autocomplete on subcommands:
linode-cli linodes list\ create\ view\ update\ delete\ backups-list\ snapshot\ backups-cancel\ backups-enable\ backup-view\ backup-restore\ boot\ clone\ configs-list\ config-create\ config-view\ config-update\ config-delete\ config-interfaces-list\ config-interface-add\ config-interface-view\ config-interface-update\ config-interface-delete\ config-interfaces-order\ disks-list\ disk-create\ disk-view\ disk-update\ disk-delete\ disk-clone\ disk-reset-password\ disk-resize\ firewalls-list\ ips-list\ ip-add\ ip-view\ ip-update\ ip-delete\ migrate\ upgrade\ nodebalancers\ linode-reset-password\ reboot\ rebuild\ rescue\ resize\ shutdown\ transfer-view\ volumes\ types\ type-view\ --help
Dropping the quotes here seems to resolve the issue on my end 👍
Suggested change
| '$actions --help' | |
| '$actions --help' |
|
@zliang-akamai Just to save you a bit of time for when you review this PR, I tested this PR with oh-my-zsh using the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
✔️ How to Test
unit test
relates to Homebrew/homebrew-core#170570