Update deploy/tagging script #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nmelehan
commented
Aug 28, 2019
nmelehan
commented
- Specify remote for push commands
- Link to GitHub new PR page
- Specify remote for push commands - Link to GitHub new PR page
stvnjacobs
reviewed
Aug 30, 2019
| echo " git push release-${version}" | ||
| echo " git push ${git_tag}" | ||
| echo " git push upstream release-${version}" | ||
| echo " git push upstream ${git_tag}" |
There was a problem hiding this comment.
I would be against hard-coding the branch to push to. These are more of a suggestion, as not everyone has an upstream branch. Some keep origin as origin and others upstream or another convention.
There was a problem hiding this comment.
Just documenting that you should be pushing to the Linode org repo should be enough, in my opinion.
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Release 1.0.14
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
[Update] API changelog 11-18-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.