-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] [deps]: New flavor for Cilium BGP load-balancing for Services, bump linode-CCM version #317
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 66.13% 66.13%
=======================================
Files 35 35
Lines 2179 2179
=======================================
Hits 1441 1441
Misses 676 676
Partials 62 62 ☔ View full report in Codecov by Sentry. |
85a3cff
to
1b21e84
Compare
78e00cf
to
29812d2
Compare
|
||
| Control Plane | CNI | Default OS | Installs ClusterClass | IPv4 | IPv6 | | ||
|---------------|--------|--------------|-----------------------|------|------| | ||
| Kubeadm | Cilium | Ubuntu 22.04 | No | Yes | No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this flavor does enable ipv6 but that's specifically because with cilium enable-host-firewall
, ipv6 must be enabled for the bgp sessions to become established
, otherwise they stay stuck in active
and the LB Services remain unreachable even in the absence of any CCNPs. Might be related to cilium/cilium#27484
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we reflect this in the doc since we are enabling dual stack now anyways?
398d7e5
to
ea11633
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it: New flavor for using the linode-CCM without creating NodeBalancers to perform Service load-balancing.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: Requires linode/linode-cloud-controller-manager#208 be merged and a new release version to be cut and published for the Helm Chart
TODOs:
Testing
Deploy a LoadBalancer service (no need to set the loadBalancerClass), and check the following:
cilium-bgp-peering=true
andnode.k8s.linode.com/ip-sharing-updated=true
once an LB Service is createdk edit md $CLUSTER_NAME-md-bgp
), the new Node eventually joins and gets thecilium-bgp-peering=true
andnode.k8s.linode.com/ip-sharing-updated=true
labels. Looking at Cloud Manager, you should see the new Linode has the shared IP for the LB Service added in the "Networking" tab.Example LB Service + CNP if you have your Cilium in enforcement mode instead of audit for the host firewall: