Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linodecluster requeue #310

Merged
merged 18 commits into from
May 20, 2024
Merged

Linodecluster requeue #310

merged 18 commits into from
May 20, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented May 7, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@komer3 komer3 marked this pull request as ready for review May 9, 2024 22:33
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 65.51%. Comparing base (107a9b5) to head (b3ba9a8).

Files Patch % Lines
controller/linodecluster_controller.go 42.10% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   65.69%   65.51%   -0.18%     
==========================================
  Files          32       32              
  Lines        1959     1975      +16     
==========================================
+ Hits         1287     1294       +7     
- Misses        612      621       +9     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 merged commit 5b6bb28 into main May 20, 2024
8 of 10 checks passed
@komer3 komer3 deleted the linodecluster-requeue branch May 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants