[vpj] send out pushjob details while hitting exception. #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2450,6 +2455,7 @@ void pollStatusUntilComplete( | |||
| VenicePushJob.this.pushJobSetting.storeResponse.getStore().getBootstrapToOnlineTimeoutInHours(); | |||
| long durationMs = System.currentTimeMillis() - pollStartTimeMs; | |||
| if (durationMs > TimeUnit.HOURS.toMillis(bootstrapToOnlineTimeoutInHours)) { | |||
| sendPushJobDetailsToController(); | |||
There was a problem hiding this comment.
Can you explain a bit about how this will help? IIUC, if an exception is thrown, the catch clause will send push job details after marking it as an ERROR
adamxchen
reviewed
Feb 29, 2024
| @@ -859,6 +859,8 @@ public void run() { | |||
| sendPushJobDetailsToController(); | |||
| closeVeniceWriter(); | |||
| } catch (Exception ex) { | |||
| sendPushJobDetailsToController(); | |||
| closeVeniceWriter(); | |||
There was a problem hiding this comment.
How about moving 859-863 to the final block if we have to invoke them anyways?
There was a problem hiding this comment.
Can we veify that the colo status is being constructed correctly? I don't see how adding more sendPushJobDetailsToController() will fix the issue of incomplete colo statuses
adamxchen
reviewed
Feb 29, 2024
| StringBuilder errorMsg = new StringBuilder().append("Push job error reported by controller: ") | ||
| .append(pushJobSetting.veniceControllerUrl) | ||
| .append("\ncontroller response: ") | ||
| .append(response); | ||
|
|
||
| sendPushJobDetailsToController(); |
There was a problem hiding this comment.
Why is this needed if we already have line 862-863?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send out pushjob details while hitting exception
During target colo push if the later push job fails, it does not send out the pushjob details to the controller, which later breaks the h2v availability report. This PR sends out pushjob details before throwing exceptions.
How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?