Rest.li V30 major release #738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junchuanwang
approved these changes
Dec 3, 2021
evanw555
approved these changes
Dec 3, 2021
The only usage of Guava in data-avro is the CaseFormat class, which is used to convert from lower case camel-case to upper case camel-case. I don't think it justifies pulling in the entire library (which is 2.1 MB in version 18 and 2.6 MB in version 28.1 plus around 1.5 MB of source). The CaseFormat class has some dependencies, including one on CaseMatcher that isn't easy to remove, so I've copied over that code from the latest version of Guava for now (manually shading them) and updated a minimum amount of code to remove other dependencies on Preconditions, Converter, and annotations.
The "dataTemplateGenerator", "restTools", and "avroSchemaGenerator" configurations have been deprecated and are now unused.
Delete mainCopyPdscSchemas and mainDestroyStaleSchemas. All LinkedIn references to this task have been removed.
This method has been deprecated since version 27.2.0, so users have had time to migrate to the preferred method. Also removes subclass method ResourceContextImpl#shouldReturnEntity.
Validate the type parameter of ActionResult, not ActionResult itself. Also improve the build error message for cases where an Action method's return type is a custom typeref but the @action parameter doesn't specify a returnTyperef attribute.
Remove avro1.4 adapter and avro1.6 related modules. Upgrade dependency on Avro to 1.9.2
evanw555
force-pushed
the
release/v30
branch
2 times, most recently
from
548e5f5
to
457b770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes following backward incompatible changes:
CustomLong) yet don't indicate thecorresponding typeref class (e.g.
CustomLongRef.class) in the@Actionannotation.returnTyperefannotation element is required for custom tyeprefs.ActionResult-wrapped return types (e.g.ActionResult<CustomLong>).ResourceContext#shouldReturnEntityandResourceContextImpl#shouldReturnEntity,which have been deprecated since version
27.2.0.pegasusGradle plugin.5.2.15.3data-avromodule