Fix TimingKey Memory Leak #587 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zizhong
force-pushed
the
timing_key_mem_leak
branch
from
7498a8c
to
8a3bd30
Compare
|
@nizarm Please help to review when you have time! Thanks! |
zizhong
force-pushed
the
timing_key_mem_leak
branch
from
8a3bd30
to
cf2a15c
Compare
nizarm
requested changes
Apr 21, 2021
r2-core/src/main/java/com/linkedin/r2/filter/transport/FilterChainClient.java
Outdated
Show resolved
Hide resolved
r2-core/src/main/java/com/linkedin/r2/filter/transport/FilterChainClient.java
Outdated
Show resolved
Hide resolved
r2-netty/src/main/java/com/linkedin/r2/transport/http/client/HttpClientFactory.java
Outdated
Show resolved
Hide resolved
zizhong
force-pushed
the
timing_key_mem_leak
branch
from
3b95e81
to
b5d2802
Compare
nizarm
approved these changes
May 3, 2021
| @@ -53,6 +59,7 @@ | |||
| * | |||
| * @param client the {@link TransportClient} to be composed. | |||
| * @param filters the {@link FilterChain} to be composed. | |||
| * @param sharedFilters the {@link FilterChain} can be used by other clients. | |||
There was a problem hiding this comment.
This java doc can be removed now right?
zizhong
force-pushed
the
timing_key_mem_leak
branch
from
b5d2802
to
83bb325
Compare
|
@nizarm Thank you for the insightful suggestions and careful reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found in #587.