Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Gradle wrapper to 6.1 #566

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Bump Gradle wrapper to 6.1 #566

wants to merge 1 commit into from

Conversation

DPUkyle
Copy link
Member

@DPUkyle DPUkyle commented Mar 23, 2021 •
edited

@DPUkyle
Bump Gradle wrapper to 6.1
ae86782 
 - This change does not require the consumer to use Gradle 6.1
 - Forthcoming opt-in features to improve metadata publishing will require Gradle 6.1 (linkedin#565)
 - Fixes to linkedin#561 require Gradle 5.4 or higher
This was referenced Mar 23, 2021
Draft
Merged
aman1309
aman1309 reviewed Mar 29, 2021
View reviewed changes
gradlew

# Collect all arguments for the java command, following the shell quoting and substitution rules
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"

# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm this is not needed now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing.

This script (and its comments) are autogenerated by Gradle - I don't plan to test them.

aman1309
aman1309 reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@aman1309 aman1309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IncrementalTaskInputs seems to be deprecated with 6.1 can you find a replacement, rest lgtm

@DPUkyle
Copy link
Member Author

DPUkyle commented Mar 30, 2021

IncrementalTaskInputs seems to be deprecated with 6.1 can you find a replacement, rest lgtm

Thanks Aman. Yes, that deprecation is addressed by #567 (upon which this PR depends).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aman1309 aman1309 aman1309 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DPUkyle @aman1309