Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storageType field to HouseTable Entity #81

Merged
merged 7 commits into from
May 7, 2024
Merged

Add storageType field to HouseTable Entity #81

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8ff7d67
Add storageType field to HouseTable Entity #80
ctrezzo Apr 22, 2024
44802a6
Merge branch 'linkedin:main' into ctrezzo/hts-storagetype
ctrezzo Apr 26, 2024
1a77ada
Merge branch 'linkedin:main' into ctrezzo/hts-storagetype
ctrezzo May 3, 2024
fc02dc4
Trigger build
HotSushi Apr 29, 2024
41c0af2
Add HouseTable unit test and fix default for storageType field.
ctrezzo May 3, 2024
37764d1
Merge branch 'linkedin:main' into ctrezzo/hts-storagetype
ctrezzo May 6, 2024
cd15744
Empty commit to trigger build
ctrezzo May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ternalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/model/HouseTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ public class HouseTable {
private long lastModifiedTime;

private long creationTime;

private String storageType;
HotSushi marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions ...java/com/linkedin/openhouse/internal/catalog/repository/HouseTableRepositoryImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ public void testRepoSave() {
Assertions.assertEquals(result.getDatabaseId(), HOUSE_TABLE.getDatabaseId());
Assertions.assertEquals(result.getTableLocation(), HOUSE_TABLE.getTableLocation());
Assertions.assertEquals(result.getTableVersion(), HOUSE_TABLE.getTableVersion());
Assertions.assertEquals(result.getStorageType(), HOUSE_TABLE.getStorageType());
}

@Test
Expand Down
3 changes: 3 additions & 0 deletions ...c/testFixtures/java/com/linkedin/openhouse/internal/catalog/HouseTableModelConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public class HouseTableModelConstants {
.tableLocation("loc1")
.tableVersion(String.valueOf(new Random().nextLong()))
.tableUUID(UUID.randomUUID().toString())
.storageType("st")
.build();

public static final HouseTable HOUSE_TABLE_SAME_DB =
Expand All @@ -36,6 +37,7 @@ public class HouseTableModelConstants {
.tableLocation("loc2")
.tableVersion(String.valueOf(new Random().nextLong()))
.tableUUID(UUID.randomUUID().toString())
.storageType("st")
.build();

public static final HouseTable HOUSE_TABLE_DIFF_DB =
Expand All @@ -47,5 +49,6 @@ public class HouseTableModelConstants {
.tableLocation("loc3")
.tableVersion(String.valueOf(new Random().nextLong()))
.tableUUID(UUID.randomUUID().toString())
.storageType("st")
.build();
}