Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug to remove internal key when receiving the 100-continue header #2781

Merged
merged 1 commit into from
May 8, 2024

Conversation

SophieGuo410
Copy link
Contributor

@SophieGuo410 SophieGuo410 commented May 8, 2024

This pr is to fix the bug that for 100-continue header support, the request will have some internal header after we handle request and send back 100-continue to customer. And in preProcessRequest we will return bad_request if any request has internal key during pre process stage.
This pr is to remove those internal args for 100-continue use case specifically.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (52ba813) to head (8c93473).
Report is 6 commits behind head on master.

Files Patch % Lines
...in/java/com/github/ambry/rest/MockRestRequest.java 25.00% 3 Missing ⚠️
...om/github/ambry/frontend/AmbrySecurityService.java 50.00% 1 Missing and 1 partial ⚠️
...java/com/github/ambry/rest/WrappedRestRequest.java 0.00% 1 Missing ⚠️
...om/github/ambry/tools/perf/rest/PerfNioServer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2781      +/-   ##
============================================
+ Coverage     64.24%   70.26%   +6.02%     
- Complexity    10398    11682    +1284     
============================================
  Files           840      840              
  Lines         71755    71876     +121     
  Branches       8611     8635      +24     
============================================
+ Hits          46099    50504    +4405     
+ Misses        23004    18740    -4264     
+ Partials       2652     2632      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SophieGuo410 SophieGuo410 requested a review from snalli May 8, 2024 03:28
@SophieGuo410 SophieGuo410 marked this pull request as ready for review May 8, 2024 03:55
@SophieGuo410 SophieGuo410 merged commit eae3750 into linkedin:master May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants