Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out mount path when replica token file fail to deserialize #2746

Closed

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

When replication manager starts, it will read the remote replica tokens from a file, and then try to deserialize it. When it fails on deserialization, the ambry-server would fail to start. However, we are not able to see from the log or stack trace which replica file is not able to deserialize. This PR would make sure we print that information out.

Test

Unit test

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.65%. Comparing base (4a4ee68) to head (96dd63d).

Files Patch % Lines
...ithub/ambry/replication/ReplicaTokenPersistor.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2746      +/-   ##
============================================
- Coverage     70.65%   70.65%   -0.01%     
- Complexity    11584    11586       +2     
============================================
  Files           833      833              
  Lines         71007    71009       +2     
  Branches       8532     8532              
============================================
- Hits          50171    50170       -1     
- Misses        18208    18213       +5     
+ Partials       2628     2626       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants