Fix metric deletion on group delete #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `burrow_kafka_topic_partition_status` metric for a deleted consumer group was dangling because we neglected to clear the corresponding gauge.
…eted Previously, we deleted the all consumer group metrics when a group's topic was deleted. WIth this change we make sure to check for the case where a topic is provided (i.e. user wants to delete only a specific topic of a consumer group) and delete only the metrics that match both consumer group and topic.
Usiel
changed the title
* master: Update Alpine to 3.19 Update Go to 1.22 Update dependencies Bump golang.org/x/net from 0.17.0 to 0.23.0 Bump golang.org/x/crypto from 0.14.0 to 0.17.0 Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 Update Go to 1.21.8 Update to golintci version that is compatible with go 1.21.x and update golintci configuration to emulate the behavior of the older version
|
I fixed the Lint issue for the new code. Let me know if there's anything else. |
|
Many thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 related fixes:
Deleting ALL metrics of a consumer group
The
burrow_kafka_topic_partition_statusmetric for a deleted consumer group was dangling because we neglected to clear the corresponding gauge.Fixes #797
Handling the case when user only deletes a specific consumer group's topic
Previously, we deleted all consumer group metrics when a group's topic was deleted. With this change we make sure to check for the case where a topic is provided (i.e. user wants to delete only a specific topic of a consumer group) and delete only the metrics that match both consumer group and topic.