Updated rootpath validation method in zookeeper coordinator #438
+43
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 3, 2018 09:25
Validate rootpath with Exists instead of Create to avoid 'zk: not authenticated' error
Fixed bug: mock Exists
Fixed bug: zookeeper exists err
Add zookeeper coordinator test on Exists method
Fixed bug: add zookeeper coordinator test on Exists method
Fixed bug: Exists return err message
Update zookeeper coordinator test - Exists return type
Update zookeeper coordinator test - Exists & Create
Fixed zookeeper coordinator test - Exists
Fixed protocol.go formatting issue: LF will be relaced by CRLF
gofmt fix on changed files
Modify coordinator to increase test coverage
Modify coordinator to fix build error
Modify errExists
Modify order of method calls in zk coordinator test
Bug fix: zk coordinator test last Exists call return &zk.Stat{}
Remove return errExist to improve test coverage
Add test cases to helpers - validation_test
Allow blank hostname in TestValidateHostList
Allow blank hostname in ValidateHostPort
Fix broken zk coordinator and allow space in consumer name
|
This change would be fine. However, your PR contains a lot of unrelated changes. Please fix the PR to contain only the changes/tests that are appropriate. |
|
Hey @cluyihunter any chance you're going to clean this up? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Previous pull request closed due to messy commits)
Validate rootpath with Exists instead of Create to avoid 'zk: not authenticated' error.
Solved the problem on Issue #347 if rootpath already exists on a pre-configured zookeeper server.