Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements #316

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Test improvements #316

wants to merge 5 commits into from

Conversation

akx
Copy link

@akx akx commented Feb 15, 2023 •
edited

This PR (required for #313):

  • refactors tests to split them into more files so they need to be annotated less when PIL is not available
  • rewrites the unittest-style assertions to regular assertions (since pytest is being used to run things)
  • rewrites the unittest-style tests to pytest-style functions (and pytest-style fixtures)
  • parametrizes tests to get rid of redundant code

@akx akx marked this pull request as draft February 15, 2023 15:24
@akx akx marked this pull request as ready for review February 16, 2023 18:17
@akx akx mentioned this pull request Feb 16, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@akx