Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default path that assetic can handle #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RubenHarms
Copy link
Contributor

Why should we pointing the default paths to locations where assetic it can't handle? We should use views/ by default.

Why should we pointing the default paths to locations where assetic it can't handle? We should use  views/ by default.
@lsmith77
Copy link
Contributor

can you elaborate a bit what you mean? indeed its a known issue that assetic cannot pick up assets in all locations but I do not see what alternative we have

@RubenHarms
Copy link
Contributor Author

Hi Ismith, you are right! At this moment there are no well known alternatives for this problem. But in the entire README.md we point to locations those are not compatible with assetic.

For example in the top of the readme: In your bundle directory it will look under Resources/themes/ or fall back to the normal Resources/views if no matching file was found. Why don't we use Resources/views/themes/ as default path?

I spend 4 hours to use paths like: App/Resources/views/themes/mytheme/MyBundle/Default/index.html.twig (this path is compatible with assetic and it's possible to bundle the templates in one location)

I have to mention that one of the major time spending issue was the %app_path% with wrong explaination, anyway if we suggest default assetic compatible paths, a lot more people enjoying this wonderful bundle.

What do you think?

@lsmith77
Copy link
Contributor

Hmm .. not sure why we never considered this (a long time ago we made this decision .. not sure if I am forgetting something) .. it feels a bit iffy to have the themes mixed in with the views but I guess one can also say its cleaner to have all templates in the same dir.

that being said, this would be a BC break which would I guess mean a new major version ..

@lsmith77
Copy link
Contributor

btw for anyone wondering about what issue is being addressed here:
https://github.com/liip/LiipThemeBundle#assetic-dump-do-not-check-resourcesthemeviews-

@dbu
Copy link
Member

dbu commented Mar 24, 2015

is this fixed by https://github.com/liip/LiipThemeBundle#assetic-integration ? the above link no longer works.

@lsmith77
Copy link
Contributor

lsmith77 commented Apr 3, 2015

ping

@lsmith77 lsmith77 added this to the 1.3.0 milestone May 10, 2015
@lsmith77 lsmith77 modified the milestones: 1.3.0, 1.4.0 Aug 28, 2015
@lsmith77
Copy link
Contributor

@thormeier / @dbu can you check this?

@lsmith77 lsmith77 removed this from the 1.4.0 milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants