feat(@clayui/core): adds new width API for the picker #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat270
reviewed
Apr 25, 2024
matuzalemsteles
force-pushed
the
LPD-23824
branch
from
d314ee8
to
29db935
Compare
pat270
reviewed
Apr 26, 2024
|
@matuzalemsteles I completely misunderstood. I thought we were talking about the button width. I think fixed width for the picker menu is fine. LGTM! |
ethib137
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket LPD-23824
Well basically we are adding the
widthAPI to define the size behavior of the Picker Panel, when marking theflexibleAPI the panel will adapt to the size of the trigger and the minimum of 160px or fixed with the minimum of 160px. I believe this is a simple API rather than having an API that the developer can define the size of because it is not responsive and this adds a lot of flexibility beyond what is described.