feat(@clayui/css): Add new icons: content-shield, scim, shield-asterisk #5804
Conversation
| * SPDX-License-Identifier: BSD-3-Clause | ||
| --> | ||
| <svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> | ||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M0 1.625V11.375C0 12.2713 0.728394 13 1.625 13H7V11.375H1.625V1.625H11.375V6H13V1.625C13 0.728716 12.2716 0 11.375 0H1.625C0.728394 0 0 0.728716 0 1.625ZM9.75 4.0625C9.75 4.95997 9.0224 5.6875 8.125 5.6875C7.2276 5.6875 6.5 4.95997 6.5 4.0625C6.5 3.16503 7.2276 2.4375 8.125 2.4375C9.0224 2.4375 9.75 3.16503 9.75 4.0625ZM3.25 5.6875L4.875 2.4375L6.5 5.6875H3.25ZM7.00002 9V10H3.50007C2.81257 10 2.84382 9 3.50007 9H7.00002ZM7.00002 8V7.42425C6.999 7.29597 7.03622 7.17011 7.10724 7.06172C7.12131 7.04026 7.13658 7.01966 7.15296 7H3.5C2.84375 7 2.8125 8 3.5 8H7.00002Z" fill="#6B6C7E"/> |
There was a problem hiding this comment.
@SelenaAungst we need to remove fill="#6B6C7E" from the paths. This prevents us from changing the color of the icon.
| * | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| --> | ||
| <svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Right now viewBox="0 0 16 16" won't work with the clay-icon tag in DXP. It's hardcoded to be viewBox="0 0 512 512". We need the viewBox="0 0 512 512" version until we can convert everything to 0 0 16 16.
SelenaAungst
force-pushed
the
LPD-21829
branch
2 times, most recently
from
4da249d
to
9914dbe
Compare
|
Hi @pat270, |
|
@SelenaAungst we can't change the viewBox manually here. We need Lexicon to provide us with svg's that are 512 x 512. |
| * SPDX-License-Identifier: BSD-3-Clause | ||
| --> | ||
| <svg viewBox="0 0 512 512" xmlns="http://www.w3.org/2000/svg"> | ||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M0 1.625V11.375C0 12.2713 0.728394 13 1.625 13H7V11.375H1.625V1.625H11.375V6H13V1.625C13 0.728716 12.2716 0 11.375 0H1.625C0.728394 0 0 0.728716 0 1.625ZM9.75 4.0625C9.75 4.95997 9.0224 5.6875 8.125 5.6875C7.2276 5.6875 6.5 4.95997 6.5 4.0625C6.5 3.16503 7.2276 2.4375 8.125 2.4375C9.0224 2.4375 9.75 3.16503 9.75 4.0625ZM3.25 5.6875L4.875 2.4375L6.5 5.6875H3.25ZM7.00002 9V10H3.50007C2.81257 10 2.84382 9 3.50007 9H7.00002ZM7.00002 8V7.42425C6.999 7.29597 7.03622 7.17011 7.10724 7.06172C7.12131 7.04026 7.13658 7.01966 7.15296 7H3.5C2.84375 7 2.8125 8 3.5 8H7.00002Z"/> |
There was a problem hiding this comment.
@SelenaAungst these indent's are using spaces. It should be tabs. Your code editor should have something that can convert to tabs.
|
Thanks for pointing this out! I think I resolved those issues, please let me know if there is anything else I can add/change for this @pat270 |
|
@SelenaAungst I'm getting this
|
|
@marcoscv-work can we get these icons in 512 x 512? I'm still working on the 16x16. There are some inconsistencies in the icons we need to work through together. |
|
@pat270 hmm yeah I am not seeing them now either after changing to 512 |
|
@SelenaAungst I was able to change the size export them from Lexicon's Icon Figma Library. |
|
Thanks @pat270! |
https://liferay.atlassian.net/browse/LPD-21829