Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clayui.com): Move input-group to own section #5803

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Apr 10, 2024

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one doubt I still have regarding whether we should keep these examples that are in the Markup tab or if we want to keep just a few use cases like we are doing in other components. @drakonux @emiliano-cicero thoughts? I didn't see anything explicit about this in the ticket or document just to know if this is ok.

@drakonux
Copy link
Member

Separating these items is recommended, especially since we'll need to provide extensive design documentation for input groups. If you could review how we're currently giving input groups in the Figma library, we may be able to improve the content.

image

After speaking with @marcoscv-work, it seems that input groups are used in multiple cases, so for us, they are just the ones included in the Figma Library.

@matuzalemsteles
Copy link
Member

Thanks @drakonux. @pat270 you can check this, apparently everything is ok.

@pat270
Copy link
Member Author

pat270 commented Apr 17, 2024

@matuzalemsteles I updated the examples to better match with examples in the Figma.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit 81634b7 into liferay:master Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants