-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@clayui/card): Radio Card component variant #5797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @veroglez for this! Would this perhaps be interesting for other cards as well?
b706bb7
to
a6078bb
Compare
Hi @matuzalemsteles! I've updated the PR by adding the radio selectable type and truncate props for CardWithUser and CardWithHorizontal. Could you take a look? On the other hand, the CI/stats has failed but I'm not sure what it refers to. Do I have to update something? Thanks in advance! 😄 |
@veroglez thanks for the work on this!
Ah, the failure is because the package size limit has been exceeded, you can increase this to 151kb without problems in https://github.com/liferay/clay/blob/master/package.json#L10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again @veroglez for working on this!
…n checkbox and radio
…ard text is truncated or not
18a0d2e
to
daaf917
Compare
Perfect! It seems that all checks have passed. Thank you very much for your help and your feedback! |
Hi guys!
According to this issue https://liferay.atlassian.net/browse/LPD-1261, on the Echo team we need a new variant of cards that have radio buttons, so here I'm sending a solution for this.
A new prop has been added, which is
selectableType
. This prop defines whether the selectable element will have a checkbox or a radio button. In addition, AradioProps
prop is also added to be able to pass the necessary props to the radio input. Along with all this, a new case in storybook has been added with two radio cards, to see the behavior of these cards:radioCard.mov
Finally, to give the user the option of not truncating the text (it's another requirement in our design and in general accessibility), a new
truncate
prop has been added to CardWithInfo, which is a flag that determines if the text is truncate or not.Let me know what you think about the solution, any feedback is welcome 😄.
Thanks in advance!
cc @marcoscv-work