feat(@clayui/empty-state): LPD-21741 Add new SVG empty, success and search state #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and removes redundancy
matuzalemsteles
approved these changes
Apr 4, 2024
|
This is good to go but I'll wait for @pat270 to take a look at the CSS part and see if he thinks it makes sense to keep this there or we move to adding inline to the component. |
pat270
requested changes
Apr 8, 2024
…ns styles on Clay CSS
pat270
reviewed
Apr 9, 2024
pat270
reviewed
Apr 9, 2024
pat270
reviewed
Apr 9, 2024
pat270
reviewed
Apr 9, 2024
pat270
reviewed
Apr 9, 2024
…nimation when on a parent element feat(@clayui/css): LPD-21741 Adds empty state svgs to Cadmin
pat270
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
@ilzamcmed I made a minor tweak in the css. .c-prefers-reduced-motion should have been .c-prefers-reduced-motion &. I also added to Cadmin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @matuzalemsteles,
This PR is not ready, I couldn't make the success and search svg animates, only the empty state.
But you can review how I made the changes.
Thanks