Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@clayui/css): Utilities adds c-prefers-reduced-motion #5443

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Mar 28, 2023

#5339

We can add the class c-prefers-reduced-motion to the whole page or specific regions of the page similar to the cadmin class.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once we have the JS implementation we can move this to the components section to be something more general that works for JS and CSS as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matuzalemsteles sounds good. This implementation should cover all the use cases listed at #5339 (comment) since they're all using CSS classes to transition.

This won't cover transitions manually created in DXP though.

@matuzalemsteles matuzalemsteles linked an issue Mar 29, 2023 that may be closed by this pull request
@matuzalemsteles matuzalemsteles merged commit 9d97ba7 into liferay:master Mar 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complement to prefers-reduced-motion
2 participants