feat(@clayui/focus-trap): Add FocusTrap component #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veroglez
force-pushed
the
issue-5409
branch
2 times, most recently
from
95ed7e8
to
90b18ff
Compare
veroglez
force-pushed
the
issue-5409
branch
2 times, most recently
from
8c82f82
to
6aae847
Compare
matuzalemsteles
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
@veroglez looks good now, I just added a comment of a small detail but looks good to go ahead now. Thanks for working on it.
|
Hi @matuzalemsteles! I have added two commits with the tests and documentation (3c8a1df, af2e8f6) , could you take a look? Thanks in advance! |
matuzalemsteles
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes: #5409
Hi @matuzalemsteles! Here is the draft for the new FocusTrap component. I have proposed the following: the component has an active props, which is in charge of activating the focus trap. In this way, it's the responsibility of the user to activate the focus trap. It could be always activated or, for example, activate it with the click of a button.
I have also added stories for Storybook to verify its behavior (video attached). What do you think?
focusTrap.mov
TO DO: