fix(@clayui/color-picker): Update hue slider to use html range input #5156
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,9 @@ | |
| * SPDX-License-Identifier: BSD-3-Clause | ||
| */ | ||
|
|
||
| import {ClayInput} from '@clayui/form'; | ||
| import ClaySlider from '@clayui/slider'; | ||
| import React, {useState} from 'react'; | ||
|
|
||
| type Props = { | ||
| /** | ||
|
|
@@ -20,65 +19,79 @@ type Props = { | |
| value: number; | ||
| }; | ||
|
|
||
| /** | ||
| * Renders Hue component | ||
| */ | ||
| const ClayColorPickerHue = ({value = 0, onChange = () => {}}: Props) => { | ||
| const [internalValue, setInternalValue] = useState<number>(value); | ||
|
|
||
| const handleOnChangeEnd = (event: any) => { | ||
|
There was a problem hiding this comment. Since we won't have the internal state anymore, just add the |
||
| onChange(internalValue); | ||
|
|
||
| event.target.blur(); | ||
|
|
||
| event.target.focus(); | ||
| }; | ||
|
|
||
| React.useEffect(() => { | ||
| setInternalValue(value); | ||
|
Comment on lines
36
to
+37
There was a problem hiding this comment. As we are going to use the parent state There was a problem hiding this comment. I couldn't do this one due to #5156 (comment). |
||
| }, [value]); | ||
|
|
||
| return ( | ||
| <div className="clay-color-form-group"> | ||
| <ClaySlider | ||
| className="clay-color-slider clay-color-slider-hue" | ||
| max={360} | ||
| min={0} | ||
| onChange={setInternalValue} | ||
| onKeyUp={(event) => { | ||
| const arrowKeys = [ | ||
| 'ArrowDown', | ||
| 'ArrowLeft', | ||
| 'ArrowRight', | ||
| 'ArrowUp', | ||
| ]; | ||
|
|
||
| if (arrowKeys.indexOf(event.key) > -1) { | ||
| handleOnChangeEnd(event); | ||
| } | ||
| }} | ||
| onPointerUp={handleOnChangeEnd} | ||
| showTooltip={false} | ||
| step={1} | ||
| style={{ | ||
| color: `hsl(${internalValue}, 100%, 50%)`, | ||
| }} | ||
| value={internalValue} | ||
| /> | ||
| <ClayInput.Group> | ||
| <ClayInput.GroupItem> | ||
| <ClayInput | ||
| data-testid="hInput" | ||
| insetBefore | ||
| max="360" | ||
| min="0" | ||
| onChange={(event) => { | ||
| const value = event.target.value; | ||
|
|
||
| let newVal = Number(value); | ||
|
|
||
| if (newVal < 0) { | ||
| newVal = 0; | ||
| } else if (newVal > 360) { | ||
| newVal = 360; | ||
| } | ||
|
|
||
| onChange(newVal); | ||
| }} | ||
| type="number" | ||
| value={value} | ||
| /> | ||
| <ClayInput.GroupInsetItem before tag="label"> | ||
| H | ||
| </ClayInput.GroupInsetItem> | ||
| </ClayInput.GroupItem> | ||
| </ClayInput.Group> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need another state here, because we also have a state in the parent component, in which case we have access to them which are
valueandonChangeit is easier to maintain a source of truth than to have multiple states and keep synchronizing them all, this is also bad because of unnecessary rerenders.