Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the Collection pattern to the Autocomplete component #5100

Closed
Tracked by #5032
matuzalemsteles opened this issue Sep 19, 2022 · 1 comment · Fixed by #5121
Closed
Tracked by #5032

Adds the Collection pattern to the Autocomplete component #5100

matuzalemsteles opened this issue Sep 19, 2022 · 1 comment · Fixed by #5121
Assignees
@matuzalemsteles
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Milestone
Solid components ...

Comments

@matuzalemsteles
Copy link
Member

From #5032

The new Collection pattern adds consistency to all Clay components to decrease the learning curve, bring React patterns, improve component composition...to read more about the new pattern in Clay, read the technical implementation of the RFC.
@matuzalemsteles matuzalemsteles added type: enhancement Issues that are open to bring improvements or refinement of code comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Sep 19, 2022
@matuzalemsteles matuzalemsteles mentioned this issue Sep 19, 2022
Open
15 tasks
@matuzalemsteles matuzalemsteles self-assigned this Sep 21, 2022
@matuzalemsteles
Copy link
Member Author

matuzalemsteles commented Sep 22, 2022 •
edited

Adding the Collection pattern to Autocomplete requires us to work on remodeling some things on Autocomplete, currently the component is quite verbose and doesn't provide many features like focus control, better integration with data provider, accessibility and needs DropDown.ItemList to render properly, some things we can abstract to simplify the implementation, there's a lot left for developers to implement that was a component composition and design.

We need to work on that first before implementing the Collection pattern. I'll create a separate issue #5106 to work on this before I get to this issue.

This was referenced Sep 22, 2022
Closed
Merged
@matuzalemsteles matuzalemsteles mentioned this issue Oct 1, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
Solid components foundation
Development

Successfully merging a pull request may close this issue.

feat(@clayui/autocomplete): add the Collection pattern and loading state matuzalemsteles/clay
1 participant
@matuzalemsteles