LPS-189491 Replace Collapse by ClayPanel #12752

veroglez · 2023-07-06T13:33:03Z

Dear frontend reviewer,

There are several things that the ClayPanel component doesn't have by default, such as a c-inner and styles defined in Lexicon. I have opened a question here liferay/clay#5624 for Clay and we have to wait for it to be solved before merging this code.

liferay-continuous-integration · 2023-07-06T13:33:06Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

veroglez · 2023-07-06T13:33:11Z

ci:test:sf

liferay-continuous-integration · 2023-07-06T13:37:11Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5363ba79d6f5607b99bc803ceb6c7b50ff779058

Sender Branch:

Branch Name: LPS-189491
Branch GIT ID: f8604223f955fc9343d553ad2f0ad5f937da76c6

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2023-07-06T13:41:24Z

Jenkins Build:test-portal-source-format#7506

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#12752

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - veroglez > liferay-echo - PR#12752 - 2023-07-06[06:33:21]

Testray Importer:publish-testray-report#28184

...s/browser/components/page_structure/components/item_configuration_panels/FormGeneralPanel.js

ealonso · 2023-08-08T11:08:42Z

Hey @veroglez,

Can we send this one? or should we wait for the clay ticket?

…e-editor-web

…-control-menu-web

…t-web

veroglez · 2023-08-08T11:20:13Z

ci:forward

liferay-continuous-integration · 2023-08-08T11:20:18Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2023-08-08T11:35:11Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29b1d6e2599e44cb3bc53e40ab8e397dc45299a6

Sender Branch:

Branch Name: LPS-189491
Branch GIT ID: 8b51a6055b9fff36baeaa076eff8758bb87df6bd

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2023-08-08T11:38:05Z

Jenkins Build:test-portal-source-format#4579

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#12752

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - veroglez > liferay-echo - PR#12752 - 2023-08-08[04:30:26]

Testray Importer:publish-testray-report#4270

liferay-continuous-integration · 2023-08-08T16:13:09Z

❌ ci:test:stable - 28 out of 29 jobs passed

❌ ci:test:relevant - 222 out of 320 jobs passed in 4 hours 45 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29b1d6e2599e44cb3bc53e40ab8e397dc45299a6

Upstream Comparison:

Branch GIT ID: 29b1d6e2599e44cb3bc53e40ab8e397dc45299a6
Jenkins Build URL: EE Development Acceptance (master) - 4731 - 2023-08-07[20:39:24]

ci:test:stable - 28 out of 29 jobs PASSED

1 Failed Jobs:

build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- ~~functional-smoke-tomcat90-mysql57-jdk8_stable/0/0~~
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-mysql57-jdk8
- portal-license-smoke-mysql57-jdk8/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

28 Successful Jobs:

ci:test:relevant - 222 out of 320 jobs PASSED

98 Failed Jobs:

222 Successful Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration · 2023-08-08T16:16:34Z

❌ ci:test:stable - 27 out of 29 jobs passed

❌ ci:test:relevant - 221 out of 320 jobs passed in 4 hours 43 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29b1d6e2599e44cb3bc53e40ab8e397dc45299a6

Upstream Comparison:

Branch GIT ID: 29b1d6e2599e44cb3bc53e40ab8e397dc45299a6
Jenkins Build URL: EE Development Acceptance (master) - 4731 - 2023-08-07[20:39:24]

ci:test:stable - 27 out of 29 jobs PASSED

2 Failed Jobs:

build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- ~~functional-smoke-tomcat90-mysql57-jdk8_stable/0/0~~
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
pmd-jdk8
- pmd-jdk8/0/0
portal-license-smoke-mysql57-jdk8
- ~~portal-license-smoke-mysql57-jdk8/0/0~~
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

27 Successful Jobs:

ci:test:relevant - 221 out of 320 jobs PASSED

99 Failed Jobs:

221 Successful Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration · 2023-08-08T16:41:07Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4906

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#12752

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - veroglez > liferay-echo - PR#12752 - 2023-08-08[04:23:55]

Testray Importer:publish-testray-report#9116

liferay-continuous-integration · 2023-08-08T16:41:42Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6563

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#12752

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - veroglez > liferay-echo - PR#12752 - 2023-08-08[04:30:45]

Testray Importer:publish-testray-report#13555

alessandromalves · 2023-08-08T19:54:46Z

ci:test:bundle

alessandromalves · 2023-08-08T20:55:38Z

I requested CI to generate a bundle because when doing it locally an error message was appearing when I was up the portal, and it did not appear to be something related to my local environment.

liferay-continuous-integration · 2023-08-09T03:07:18Z

✔️ ci:test:bundle - 1 out of 1 jobs passed in 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffa3ce6483f058300d4476a5580521483e51f411

Upstream Comparison:

Branch GIT ID: ffa3ce6483f058300d4476a5580521483e51f411
Jenkins Build URL: EE Development Acceptance (master) - 4733 - 2023-08-08[12:43:32]

ci:test:bundle - 1 out of 1 jobs PASSED

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2023-08-09T03:18:01Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4157

Jenkins Report:jenkins-report.html

Jenkins Suite:bundle

Pull Request:liferay-echo#12752

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:bundle - veroglez > liferay-echo - PR#12752 - 2023-08-08[19:17:32]

Testray Importer:publish-testray-report#9130

alessandromalves · 2023-08-09T22:13:07Z

Apparently the related failures will only need a test fix. See #13221

alessandromalves · 2023-08-09T22:13:34Z

ci:close

veroglez added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jul 6, 2023

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jul 6, 2023

victorg1991 self-assigned this Jul 6, 2023

victorg1991 added the 🛑 On Hold Pull request is blocked and should not be forwarded. label Jul 6, 2023

victorg1991 reviewed Jul 6, 2023

View reviewed changes

...s/browser/components/page_structure/components/item_configuration_panels/FormGeneralPanel.js Outdated Show resolved Hide resolved

veroglez force-pushed the LPS-189491 branch from f860422 to f35b52b Compare July 6, 2023 21:55

victorg1991 removed the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jul 7, 2023

victorg1991 removed their assignment Jul 7, 2023

veroglez force-pushed the LPS-189491 branch from f35b52b to bcccc1e Compare July 28, 2023 08:16

ealonso added the ⚠️ Merge Conflict Pull request can't be merged due to conflicts with master. label Aug 4, 2023

veroglez added 5 commits August 8, 2023 13:10

LPS-189491 Replace custom Collapse by ClayPanel in layout-content-pag…

4ad3dd6

…e-editor-web

LPS-189491 Replace custom Collapse by ClayPanel in template-web

805fc53

LPS-189491 Replace custom Collapse by ClayPanel in stylebook-web

085e969

LPS-189491 Replace custom Collapse by ClayPanel in product-navigation…

4a34973

…-control-menu-web

LPS-189491 Replace custom Collapse by ClayPanel in object-js-componen…

1ddc31c

…t-web

veroglez force-pushed the LPS-189491 branch from bcccc1e to 4aff514 Compare August 8, 2023 11:14

veroglez added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🛑 On Hold Pull request is blocked and should not be forwarded. ⚠️ Merge Conflict Pull request can't be merged due to conflicts with master. labels Aug 8, 2023

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - success labels Aug 8, 2023

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:relevant - failure ci:test:stable - pending labels Aug 8, 2023

alessandromalves self-assigned this Aug 8, 2023

alessandromalves removed their assignment Aug 8, 2023

Repository owner deleted a comment from liferay-continuous-integration Aug 8, 2023

Tim-Cao added 🔍 QA Review Needed 🛠 Changes Required Code has been reviewed and needs changes. labels Aug 8, 2023

Tim-Cao assigned alessandromalves Aug 8, 2023

liferay-continuous-integration added ci:test:bundle - pending and removed ci:test:bundle - pending labels Aug 9, 2023

sandrodw3 removed the ✅ Ready to Merge Pull request is ready and can be forwarded. label Aug 9, 2023

alessandromalves mentioned this pull request Aug 9, 2023

LPS-189491 Replace Collapse by ClayPanel #13221

Closed

liferay-continuous-integration closed this Aug 9, 2023

LPS-189491 Replace Collapse by ClayPanel #12752

LPS-189491 Replace Collapse by ClayPanel #12752

Conversation

veroglez commented Jul 6, 2023

liferay-continuous-integration commented Jul 6, 2023

veroglez commented Jul 6, 2023

liferay-continuous-integration commented Jul 6, 2023

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 6, 2023

ealonso commented Aug 8, 2023

veroglez commented Aug 8, 2023

liferay-continuous-integration commented Aug 8, 2023

liferay-continuous-integration commented Aug 8, 2023

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Aug 8, 2023

liferay-continuous-integration commented Aug 8, 2023

❌ ci:test:stable - 28 out of 29 jobs passed

❌ ci:test:relevant - 222 out of 320 jobs passed in 4 hours 45 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

98 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Aug 8, 2023

❌ ci:test:stable - 27 out of 29 jobs passed

❌ ci:test:relevant - 221 out of 320 jobs passed in 4 hours 43 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

99 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Aug 8, 2023

liferay-continuous-integration commented Aug 8, 2023

alessandromalves commented Aug 8, 2023

alessandromalves commented Aug 8, 2023

liferay-continuous-integration commented Aug 9, 2023

✔️ ci:test:bundle - 1 out of 1 jobs passed in 49 minutes

Base Branch:

Upstream Comparison:

For more details click here.

Test bundle downloads:

liferay-continuous-integration commented Aug 9, 2023

alessandromalves commented Aug 9, 2023 • edited

alessandromalves commented Aug 9, 2023

alessandromalves commented Aug 9, 2023 •

edited