Coordinate Trainer: option for coordinates on every square #15221
Conversation
|
first attempt, but there still seems to be an issue with i18n flow |
|
I realize now I mistakenly tried to update a node modules file |
|
Glad to see someone take this on. I'll just link it to the issue with: fixes #15212 |
* master: (29 commits) move app rate limiters to web Revert necessary import for pipe ensure all rate limiters are configured move ctrl limiters to web - WIP scala tweaks report donation stats every 24h New Crowdin updates (lichess-org#15226) chessground redrawAll scss tweaks put is3d in board change event prettier Don't refetch same css, cached or no brightness/opacity on last move & check squares, but no hue rotate disable social links on kid profiles Update uap-scala to 0.17.0 Update play-json to 3.0.3 Update play-ahc-ws-standalone, ... to 2.2.7 Hide kid teams on profile comm restrictions no longer shield against comm reports remove duplicated css property ...
run |
…into opt-coords-every-sq * 'opt-coords-every-sq' of https://github.com/BSmick6/lila:
|
your move |
|
Yep it is a different issue intentionally because both need to be implemented separately. How are your CSS skills? Based on your video, it seems like there is some styling issue to be debugged. Could be an issue with your implementation or with chessground. That's the thing to look into next I'd say. Still your move! :D |
I'm familiar with CSS so I can investigate whether it's an issue in Lila at least. |
|
i also ran into the same issue when trying to do this. looks like the translateXs or something are not getting applied properly. I tried on Gitpod |
|
obviously, it isn't a long term solution but I hacked together some CSS code to at least position the coordinates correctly. this is what it looks like: |
|
After digging through more chessground code, I've concluded that a styling fix exclusive to this repo will require hard coding, mostly due to the lack of a parent element for the I can open a PR with helpful changes in the chessground repo (here), but I'm not sure what the procedure is there. @brollin lmk what you think. your move 😊 |
|
Nice investigation, yeah it's a brand new feature so not surprising that there's a kink to work out. Opening a chessground PR would be great. The procedure with that repo isn't any different from this one or most GitHub repos really. Alternatively if you aren't feeling confident you could just open an issue over there to report the problem. |
|
Working on it right now but I'm trying to get the css right before I commit anything to chessground. It's been a struggle so I might just open a draft PR and call it a day soon |
|
the latest change actually fixes everything except the rank colors from white's perspective: |
|
Yes it seems that we manually add chessground CSS to lila, perhaps because we want to be very deliberate. It looks like chessground works fine so you can close your PR over there. |
There was a problem hiding this comment.
I tried to improve/clean up the CSS code by removing unnecessary selectors and nesting others. Any and all feedback is appreciated. I plan on updating respective CSS code in the chessground repo (PR) once we've settled on the changes here.
| @@ -212,3 +212,53 @@ html.transp body:not(.simple-board) cg-board { | |||
| //filter: hue-rotate(calc(var(---board-hue) * 3.6deg)); | |||
| } | |||
| } | |||
|
|
|||
| coords.squares { | |||
There was a problem hiding this comment.
I don't love the .squares class name. Squares are referenced very often in chess. For example, chessground already uses a <square> element. I anticipate conflicts one day, but for now, we can just specify the <coords> element to mitigate that risk.
|
Thanks for these contributions @BSmick6! ornicar will eventually have a look and may adjust things. He is usually juggling about 13 tasks simultaneously, so there might be a small wait. |
white normal:
black normal:
white all squares:
black all squares:
