New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profile actions bar reworked into dropdown for mobile only #14205
base: master
Are you sure you want to change the base?
Conversation
09507c4
to
dfeedfb
Compare
66ef468
to
d421740
Compare
What the proposed change would look like (also mentioned in #13991): |
d421740
to
354b0a7
Compare
354b0a7
to
80924eb
Compare
Removed list on desktop as requested. desktop-list.mp4mobile-list.mp4 |
trans.reportXToModerators.txt(u.username) | ||
) | ||
) | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the feature idea, but I hate that all this code is duplicated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree, I couldn't find a way to make it more concise since the class names and text content had to be different for each link element. Maybe someone more experienced can help me out.
Alternatively, adding text to each link for desktop and mobile might help solve the issue as originally suggested by @kuba-orlik
This is a great change. If you can't spare the bandwidth to see it through let us know and maybe someone else can pick it up. |
4435dac
to
80924eb
Compare
Thanks, I just made an attempt at refactoring this. Not sure if there's a nicer way to do this, I'm still new to Scala. Please let me know what you think, if this is a change that is needed I am very happy to continue to work on it. |
I have made some attempts to fix your pr @awestm . Linking a pr to your fork you might still need to make some changes to _show.scss |
No description provided.