Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mxfp4 bf16 avx2 gemms #881

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

egeor
Copy link
Collaborator

@egeor egeor commented May 14, 2024

This PR enables mxfp4-bf16 (BR)gemms for non-AMX as well (for now fallback to avx2) and also generalizes these kernels for any M (before there was m % 8 ==0 requirement)

@egeor egeor marked this pull request as ready for review May 14, 2024 06:52
@egeor egeor requested a review from alheinecke May 14, 2024 06:52
Copy link
Collaborator

@alheinecke alheinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Nit

src/generator_gemm.c Show resolved Hide resolved
@alheinecke alheinecke merged commit 9534052 into main May 14, 2024
12 checks passed
@alheinecke alheinecke deleted the feature_mxfp4_bf16_avx2_gemms branch May 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants