-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved cast-qual and other warnings #837
Draft
hfp
wants to merge
1
commit into
main
Choose a base branch
from
fix_warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfp
force-pushed
the
fix_warnings
branch
2 times, most recently
from
December 15, 2023 08:48
8febe34
to
aa7aba2
Compare
Rebased on top of #838 |
Can you please break this PR into multiple smaller one. I have seen some transient CI issues which we didn't have on main. I would like to understand if they are related to changes. so breaking into smaller, non-overlapping pieces. |
* Makefile/inc - Only apply certain compiler flags if available with compiler in question. - Fixed incorrect warning when using custom compiler defined by CC/CXX. - Avoid duplicated warnings flags. - Fallback for LIBM and LIBC. * Warnings - Introduced LIBXSMM_VALUE_ASSIGN, and resolved cast-qual warnings. - Avoid GCC-specific directive and rely on family of LIBXSMM_PRAGMA_DIAG_* macros. - Fixed warnings about deprecated/unsafe function (sprintf). - Utilize LIBXSMM_PRAGMA_DIAG family of directives. - Avoid warnings about unused function. - Fixed warnings about type-truncation. - Fixed numerous compilation warnings. - Fixed dropping const-qualifier. * Macros/infra - Improved LIBXSMM_TYPEINFO to support FP-, and UI-info. Made LIBXSMM_TYPEINFO_FP, and LIBXSMM_TYPEINFO_UI separately available. - Make diagnostic-control available early, i.e., include headers with warnings suppressed. - Adjusted condition for older Clang (LIBXSMM_PRAGMA_DIAG_OFF_FADDRESS). - Made LIBXSMM_PRAGMA available more broadly. - Enable LIBXSMM_PRAGMA if GNU is pre-C99. - Fixed issues applying attribute (weak). * Other - MHD: Introduced element-handler info-struct to replace destination-type; allows for conversion hints, etc. - MHD: Updated mapping general LIBXSMM data-types to MHD. Support data-comversion handler during MHD-write. - Improved pooled allocation (hash calculation outside of macro/side-effect, streamlined variable names). - Revised implementation of libxsmm_coprime mainly to have more sensible result in case of minco=0. - Improved libxsmm_print_cmdline and made prefix/postfix optional arguments. - Print PID as part of "Command" info (verbose termination message). - Made LIBXSMM_ATOMIC_ACQUIRE macro an own block (do/while pattern). - Fixed libxsmm_offset and implemented test. - Adjusted definition of libxsmm_coprime2. * Cleanup - Deleted libxsmm_ext.h header-file. Removed LIBXSMM_CONST_VOID_PTR. - Revised interface of libxsmm_pfree and improved malloc-test (const). - Documentation: updated settings according to documentation (RTD). - Cleanup embedded build options (LIBXSMM_DUMP_BUILD). - Corrected location of header files (VS project). - Updated VS project (new translation units). - Updated MkDocs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile/inc
Warnings
Macros/infra
Other
Cleanup