Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate FreeBSD port patches #16221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehaupt
Copy link

@ehaupt ehaupt commented Feb 10, 2024

Description

This commit integrates a series of patches from the FreeBSD port, enhancing build compatibility and resolving specific FreeBSD-related issues. They tackle a variety of issues, including compiler warnings and system-specific dependencies.

Related Issues

  • No specific issues in the upstream repository are directly addressed by this pull request. However, it aims to preemptively solve potential build and compatibility problems for FreeBSD users.

Related Pull Requests

  • None. This is a standalone pull request, requiring no dependent changes from related repositories.

@LibretroAdmin
Copy link
Contributor

Can you fix the failed CI build error?

@ehaupt
Copy link
Author

ehaupt commented Feb 18, 2024

Apparently, the FreeBSD macro is also activated for the ORBIS builds, which I did not anticipate. I'll try a few things and will squash the commits if the pipeline reports success.

This commit imports a series of patches from the FreeBSD port of RetroArch to
improve build compatibility and address specific issues encountered in the
FreeBSD environment. These patches, sourced from the FreeBSD Ports collection
(https://cgit.freebsd.org/ports/tree/games/retroarch/files), have been adapted
and tested to ensure they integrate seamlessly with the current build process.
@ehaupt
Copy link
Author

ehaupt commented Feb 18, 2024

I've fixed the PS4/ORBIS CI build and squashed all the commits.

Is there any chance we could get a FreeBSD amd64 CI runner?

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Feb 18, 2024
Incorporate changes from a pull request for improved traceability and
documentation.

See libretro/RetroArch#16221

This is a NOP change and does not warrant a PORTREVISION bump.
@gouchi
Copy link
Member

gouchi commented Feb 19, 2024

Is there any chance we could get a FreeBSD amd64 CI runner?

We will need to add Cirrus CI or Travis CI ?

We have Travis but it will need some update to make it work again (was used for coverity scan IIRC).

@ehaupt
Copy link
Author

ehaupt commented Feb 19, 2024

We will need to add Cirrus CI or Travis CI ?

We have Travis but it will need some update to make it work again (was used for coverity scan IIRC).

I'd go with Travis if you already got it. But there is no hurry. It would be nice to have.

@ehaupt
Copy link
Author

ehaupt commented Mar 22, 2024

Hi @gouchi, I was wondering if we might have an opportunity to merge this while it's conflict-free? Also, if you think it would be helpful, I'm more than willing to open a separate issue to discuss the pipeline in more detail. Please let me know your thoughts or if there's anything else I can do to assist. Thanks so much for your time and efforts!

@gouchi
Copy link
Member

gouchi commented Mar 23, 2024

@ehaupt Sure we can discuss the pipeline in more detail to a separate issue to enable FreeBSD CI test.

@LibretroAdmin CI build error has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants