Tweak build instructions #1048
Open
Tweak build instructions #1048
+55
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomInEqualities
force-pushed
the
readme
branch
from
65c832e
to
4eaea64
Compare
joshuasing
reviewed
May 24, 2024
With the CMake version of building for windows there is support for building with MINGW, clang, and Visual Studio. CMake can build for MINGW using the regular method of autogen and CMake. Removing this makes it a bit simpler to get an overview of how to build for windows. Reducing confusion.
Since it is mingw specific and does not really involve other compilers.
In particular simplify the Windows build instructions, by only having a short CMake section about it. While mentioning that bash shell is required also on Windows up-front. Splits the build section into a section for configure and one for CMake so it is easier to pick one of them. Moves the additional CMake options into the CMake section. Moves dist.sh text into the configure section as it is configure specific.
RandomInEqualities
force-pushed
the
readme
branch
from
4eaea64
to
937a3d9
Compare
|
Thanks for the comments @joshuasing I have updated the review :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have these 3 commits that mostly tweaks the windows build instructions to have less text and be more focused. It is easy to build with Visual Studio/Clang/GCC on Windows, but there is a lot of text making it seem complicated. With CMake things are quite simple.
This mainly does 3 things: