[Windows] Mark old_report_mode as unused #1046
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a comment in the code for reference later about why this is needed? Thanks! |
vszakats
reviewed
Apr 9, 2024
crypto/compat/posix_win.c
Outdated
Comment on lines
166
to
171
| #define BEGIN_SUPPRESS_IPH \ | ||
| int old_report_mode = _CrtSetReportMode(_CRT_ASSERT, 0); \ | ||
| (void)old_report_mode; \ | ||
| _invalid_parameter_handler old_handler = _set_thread_local_invalid_parameter_handler(noop_handler) | ||
| #define END_SUPPRESS_IPH \ | ||
| _CrtSetReportMode(_CRT_ASSERT, old_report_mode); \ |
There was a problem hiding this comment.
Suggested change
| #define BEGIN_SUPPRESS_IPH \ | |
| int old_report_mode = _CrtSetReportMode(_CRT_ASSERT, 0); \ | |
| (void)old_report_mode; \ | |
| _invalid_parameter_handler old_handler = _set_thread_local_invalid_parameter_handler(noop_handler) | |
| #define END_SUPPRESS_IPH \ | |
| _CrtSetReportMode(_CRT_ASSERT, old_report_mode); \ | |
| #define BEGIN_SUPPRESS_IPH \ | |
| int old_report_mode = _CrtSetReportMode(_CRT_ASSERT, 0); \ | |
| _invalid_parameter_handler old_handler = _set_thread_local_invalid_parameter_handler(noop_handler) | |
| #define END_SUPPRESS_IPH \ | |
| (void)old_report_mode; \ | |
| _CrtSetReportMode(_CRT_ASSERT, old_report_mode); \ |
Wouldn't it be better to move the warning suppression into END_SUPPRESS_IPH? This way such warning would still correctly signal when missing an END_SUPPRESS_IPH by accident.
There was a problem hiding this comment.
Year I think that sounds good :)
When compiling in release mode the _CrtSetReportMode macro gets replaced by void(0). This makes old_report_mode unused. Silence a warning about it.
RandomInEqualities
force-pushed
the
windows
branch
from
869864c
to
8ce9710
Compare
|
I updated it and added const to the variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling in release mode the _CrtSetReportMode macro gets replaced by void(0). This makes old_report_mode unused, which visual studio warns about.