Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: deduplicate dependencies #5318

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

onur-ozkan
Copy link
Contributor

@onur-ozkan onur-ozkan commented Apr 17, 2024

Description

Helps to reduce number of dependencies by removing duplicated ones.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
transports/uds/Cargo.toml Outdated Show resolved Hide resolved
@onur-ozkan onur-ozkan changed the title deduplicate dependencies deps: deduplicate dependencies Apr 17, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for your interest! As we use dependabot to submit PR's with updates for the dependencies I don't think this is worth it.
If we downgrade tempfile dependabot will submit a PR trying to update it afaik, trying to keep track of downgraded packages and keeping ignoring upgrades for certain so that we have less package versions on Cargo.lock is therefore not worth it imho.

@onur-ozkan
Copy link
Contributor Author

Hi, and thanks for your interest! As we use dependabot to submit PR's with updates for the dependencies I don't think this is worth it. If we downgrade tempfile dependabot will submit a PR trying to update it afaik, trying to keep track of downgraded packages and keeping ignoring upgrades for certain so that we have less package versions on Cargo.lock is therefore not worth it imho.

Only the 2nd commit downgrades a dependency as pointed out at #5318 (comment). I will revert that commit since the repo has dependabot integration.

jxs
jxs previously approved these changes May 9, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label May 9, 2024
@drHuangMHT
Copy link
Contributor

Ping @jxs for stalled PR

@mergify mergify bot dismissed jxs’s stale review June 1, 2024 16:09

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 914e9c8 into libp2p:master Jun 1, 2024
72 checks passed
@onur-ozkan onur-ozkan deleted the reduce-dependencies branch June 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants