Skip to content

Commit

Permalink
Remove deprecated Object.oid
Browse files Browse the repository at this point in the history
  • Loading branch information
jdavid committed Mar 29, 2024
1 parent d71f980 commit 730414b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# 1.15.0 (UNRELEASED)

- Many deprecated features have been removed, see below

- Upgrade to libgit2 v1.8.0

- New `push_options` optional argument in `Repository.push(...)`
Expand Down Expand Up @@ -27,6 +29,7 @@ Breaking changes:

- Remove deprecated `oid.hex`, use `str(oid)`
- Remove deprecated `object.hex`, use `str(object.id)`
- Remove deprecated `object.oid`, use `object.id`

- Remove deprecated `Repository.add_submodule(...)`, use `Repository.submodules.add(...)`
- Remove deprecated `Repository.lookup_submodule(...)`, use `Repository.submodules[...]`
Expand Down
11 changes: 0 additions & 11 deletions src/object.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,6 @@ Object_id__get__(Object *self)
return git_oid_to_python(Object__id(self));
}

PyDoc_STRVAR(Object_oid__doc__,
"The object id, an instance of the Oid type.\n"
"This attribute is deprecated, please use 'id'\n");

PyObject *
Object_oid__get__(Object *self)
{
return Object_id__get__(self);
}


PyDoc_STRVAR(Object_short_id__doc__,
"An unambiguous short (abbreviated) hex Oid string for the object.");
Expand Down Expand Up @@ -300,7 +290,6 @@ Object_richcompare(PyObject *o1, PyObject *o2, int op)
}

PyGetSetDef Object_getseters[] = {
GETTER(Object, oid),
GETTER(Object, id),
GETTER(Object, short_id),
GETTER(Object, type),
Expand Down

0 comments on commit 730414b

Please sign in to comment.