Adds Depth to FetchOptions allowing for shallow cloning #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, what's next for this pull request ? |
Someone needs to review and approve it I guess. Not sure if this is something @bording could do? |
amirvenus
suggested changes
Mar 30, 2024
| /// Default value is 0 (full) fetch. | ||
| /// </para> | ||
| /// </summary> | ||
| public int Depth { get; set; } = 0; |
| // a new instance of GitFetchOptions we only populate the Depth field. | ||
| var fetchOptions = new GitFetchOptions | ||
| { | ||
| Depth = options.FetchOptions.Depth, |
There was a problem hiding this comment.
FetchOptions could be null at this point - possible NRE
| @@ -794,7 +801,7 @@ public static string Clone(string sourceUrl, string workdirPath) | |||
| } | |||
|
|
|||
| using (var checkoutOptionsWrapper = new GitCheckoutOptsWrapper(options)) | |||
| using (var fetchOptionsWrapper = new GitFetchOptionsWrapper()) | |||
| using (var fetchOptionsWrapper = new GitFetchOptionsWrapper(fetchOptions)) | |||
There was a problem hiding this comment.
We need another test for this extra options : what if it is null and being passed to the ctor?
Also, how about using using var ... (we might want to remove the brackets)
|
@amirvenus Do you have write-access and can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
DepthtoFetchOptionsallowing for shallow cloning.Since I'm new to this repo and it's complexity it's possible i've missed some key information to why this have not been implemented, and if so I'm sorry for not reading up on it prior to submitting this PR.
Resolves #229