Introduce a stricter debugging allocator for testing #6811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new debugging allocator that:
malloc
is not the same pointer that the underlying systemmalloc
used, and is therefore incompatible with the systemfree
. This helps catch inconsistent use of system malloc and the libgit2-configured malloc.realloc
to always reallocate (it will explicitlymalloc
,memcpy
, andfree
the previous pointer)Also, update some inconsistent use of allocators caught by 1.