remote: add git_refspec to update_tips #6559
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git
shows the remote and local ref information during a fetch. For example:This is not information that users of libgit2 can currently surface since our
update_tips
callback includes only src/dest OIDs, and the local ref name. Nor can one reliably reverse engineer the remote branch name, since a remote configuration could map two remote specs to a local spec. For example:In this case, given
refs/remotes/asdf/foo
in theupdate_tips
, a caller would have no idea whether the remote wasrefs/pull/foo/head
orrefs/heads/foo
.Provide the matching remote
git_refspec
so that callers canrtransform
themselves into the remote.