Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions occurring on Runnable tasks no longer swallowed #7384

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Exceptions occurring on Runnable tasks no longer swallowed #7384

merged 2 commits into from
Apr 19, 2024

Conversation

obigu
Copy link
Contributor

@obigu obigu commented Apr 19, 2024

Fixes #7046

Berstanio
Berstanio approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Berstanio Berstanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it consisten across backends and allows for proper/better exception handling, as mentioned in the issue I approve!

@NathanSweet NathanSweet merged commit 8a2504f into libgdx:master Apr 19, 2024
@obigu obigu deleted the postrunnable branch April 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokeMMO PokeMMO PokeMMO approved these changes

@Berstanio Berstanio Berstanio approved these changes

Assignees
No one assigned
Labels
android ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post runnable exceptions get omitted on Android and iOS backends
5 participants
@obigu @PokeMMO @Berstanio @NathanSweet @actions-user