Fix isPointInTriangle in 3d (#6882) #7106
Conversation
Solution have been find by tylerhasman & tommyettinger but never added
|
Thanks for revisiting this; I had forgotten about it. I'll run the Spotless tasks on this myself, since that's probably why the checks are failing, then commit to your PR (which I think should work). I'll also fix any typos I find. |
There was a problem hiding this comment.
I didn't change any code; I just ran spotlessApply and the tests, as well as cleaned up some typos, unclear phrasing, and punctuation mistakes in comments. The expanded tests all pass, and I believe the algorithm has been known to work since the original issue. I don't see any reason this can't be merged.
|
@tommyettinger thanks for formating & english check ! I thought formating was done by a Github action. When I had run it on my computer (Linux) it edit all .java file. It probably only edit end line, but I was afraid that my merge request show change in every .java file. |
|
Formatting is run by a GH Action, but to avoid the potential for spammers creating many PRs and running problematic actions on GitHub's servers, no actions will run for PRs by first-time contributors (just to be sure that it's running actions on PRs from someone it knows). You can run spotlessApply and it will claim all files have changes, but when you actually submit the PR only a few files will have actually been altered (the ones you changed by hand, usually). As you said, it is probably just changing the line endings, which Git will usually ignore when it pushes the changes. |
|
The automatic spotless fix runs on your own repository. If you don't have it enabled for the fork, it doesn't. It wasn't (and probably still isn't) possible to push from the PR build |
|
Do I need to do something else before merge ? |
Solution have been find by @tylerhasman & @tommyettinger but never merged. Closes #6882
I've add fiew more tests.
I think I's usefull to warn user that because of float use, function may return a bad answer with realy small and realy big x,y,z. But if you think it's not usefull, I can revert comment of isPointInTriangle().
Let me know if anything else should be changed.