Update VideoActor to set the batch color before drawing the video texture #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture Setting the batch color before drawing the video texture prevents other actors in the stage that modifies the batch color from tinting the video texture.
|
Hi folks. Are there any extra steps I should follow for the PR to be reviewed? Thanks! |
|
Hi, no, there aren't any extra steps. My hope was to get some reviews from some of the other contributors about whether this change makes sense, as I'm not very familiar with scene2d. I also had the hope to being able to fox the CI, but I have no clue why this error appears |
|
I got a quick look from @lyze237; looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the batch color before drawing the video texture prevents other actors in the stage that modifies the batch color from tinting the video texture.