Close #334: gdColorMatch(): doubtful algorithm #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change the algorithm of `gdColorMatch()` to calculate the Euclidean distance of the color component values, what may require to change some thresholds in existing code to match the new algorithm, as can be seen by the need to adapt gdimagecolorreplace.c.
|
Looks good to me, Thanks @cmb69 ! |
|
I think we need a 2.3.3 release, then most likely a 2.3.4. Once 2.3.3 is out (I will try today or later this week), we can branch GD_2_2 and do only sec fixes there. Master will be 2.4 then and merging this PR as well. Thoughts? |
|
It seems that GD-2.3 has already been branched. Any objections to merge this into master? |
vapier
requested changes
Nov 28, 2023
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #include "gd.h" | |||
| #include "gd_color.h" | |||
| #include <math.h> | |||
|
|
|||
| /** | |||
| * The threshold method works relatively well but it can be improved. | |||
There was a problem hiding this comment.
please update the comment docs to match what the code is doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the algorithm of
gdColorMatch()to calculate the Euclideandistance of the color component values, what may require to change some
thresholds in existing code to match the new algorithm, as can be seen
by the need to adapt gdimagecolorreplace.c.