Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gddemo.c: move from src to examples #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willson-chen
Copy link
Member

Reference to #558

@codecov-commenter
Copy link

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         251      251           
  Lines       13656    13656           
=======================================
  Hits        10394    10394           
  Misses       3262     3262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a73f68...4e841e3. Read the comment docs.

@cmb69
Copy link
Contributor

cmb69 commented May 24, 2020

Moving this file looks overdue, but I wouldn't do it in a revision (and actually not even in a minor release), so I think we should decide how to handle the next release. Will master become 2.3.1 or 2.4?

@willson-chen
Copy link
Member Author

but I wouldn't do it in a revision (and actually not even in a minor release), so I think we should decide how to handle the next release.

So it is better to leave it to GD 3?

Will master become 2.3.1 or 2.4?

Sure. We have milestone list.

@vapier
Copy link
Member

vapier commented Feb 8, 2021

time to merge!

@pierrejoye pierrejoye added this to the GD 2.4 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants