Cleanup event-config.h #1645
Open
Cleanup event-config.h #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
reviewed
May 8, 2024
| @@ -427,10 +390,6 @@ | |||
| /* Define if timerclear is defined in <sys/time.h> */ | |||
| #cmakedefine EVENT__HAVE_TIMERCLEAR 1 | |||
|
|
|||
| /* Define if timercmp is defined in <sys/time.h> */ | |||
| #cmakedefine EVENT__HAVE_TIMERCMP 1 | |||
There was a problem hiding this comment.
Changes like this should be complete, i.e removing the check for timercmp from CMake, and doing the corresponding changes in the Autotools build system at the same time. Otherwise you will (likely) end up with divergence in behaviour between the two systems.
There was a problem hiding this comment.
@Coeur let's sync the configure.ac as well
There was a problem hiding this comment.
Correct, but this is not all, you need to adjust the configure.ac for other changes, i.e. remove HAVE_TAILQFOREACH, and likely something else, I did not look deeply enough for now, please take a look
Coeur
force-pushed
the
coeur/EVENT__HAVE_TAILQFOREACH
branch
from
8d38de5
to
ccb0c2b
Compare
azat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1332.
The duplication was introduced with e415196
Also addresses partially #1329, but I only removed the stuff for which I was 100% sure it was unused.