-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to set SO_REUSEADDR and SO_REUSEPORT on Unix sockets #1625
Conversation
20902d7
to
de17e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you add a test for this? And maybe for https://github.com/libevent/libevent/pull/1616/files as well?
Working on it. |
#1582 had been merged, you can continue |
35ecf3e
to
9a2d2e9
Compare
9a2d2e9
to
3e55189
Compare
The CI builds failed automatically because of no runners available, please rerun the CI. @azat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from minor comments LGTM
It seems like there is something to do with the Unicode encoding of the temporary dir path used by this runner, I don't have a quick fix for this in mind, how can I skip this runner? @azat |
This WSAENETDOWN error kept raising when the new test tried to create an
It's really weird because this runner looks nothing different from other Windows runners but only with the Unicode system temporary path. Do you have any clue about this? @azat |
…TORY --------- Signed-off-by: Andy Pan <i@andypan.me> --------- Signed-off-by: Andy Pan <i@andypan.me>
I've skipped this test on that specific Windows runner for now, hope we can resolve this suspicious failure later. |
Ping @azat |
No clue, I'm not a windows expert, and don't want to be this kind of a person. Only Linux. |
--------- Signed-off-by: Andy Pan <i@andypan.me>
I think this PR is ready to land. @azat |
SO_REUSEADDR and SO_REUSEPORT are not supported for TCP and UDP sockets. Setting them on Unix socket via
setsockopt
somehow doesn't report an error, but it actually won't work.References
Signed-off-by: Andy Pan i@andypan.me