Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Navigation 5 #9

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lesmo
Copy link

@lesmo lesmo commented May 21, 2021

Addresses #7, so we'll now be using the latest stable version of React Navigation.

I'm not comfortable releasing this yet, as using the browser's history to move forward and back the second time raises this error:

The action 'RESET' with payload {"stale":false,"type":"stack","key":"stack-YDUoxSrlp7c_rSKXZ7GNw","index":1,"routeNames":["Home","Details"],"routes":[{"name":"Home","key":"Home-Y4E99beLSgaS3IhUFWdM7","params":{}},{"key":"Details-9CYFzWkM6ifCWd88-kRgE","name":"Details","params":{}}]} was not handled by any navigator.

This is a development-only warning and won't be shown in production.

I'm unsure what's the root cause, and I might open an issue on React Navigation's repo.

@lesmo
Copy link
Author

lesmo commented Aug 15, 2021

Waiting on react-navigation/react-navigation#9408

@lesmo lesmo self-assigned this Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant