Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-navigation 5.X #7

Open
tyrauber opened this issue Feb 9, 2021 · 1 comment
Open

Upgrade to react-navigation 5.X #7

tyrauber opened this issue Feb 9, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tyrauber
Copy link

tyrauber commented Feb 9, 2021

@lezzmo, Thanks for this.

What do you think about upgrading to react-navigation 5.X? This example is currently using the 3.X syntax, specifically createAppContainer which is no longer used in 5.x, replaced with the NavigatorContainer Syntax.

import { NavigationContainer } from '@react-navigation/native';
import { createStackNavigator } from '@react-navigation/stack';

const Stack = createStackNavigator();

export default function App() {
  return (
    <NavigationContainer>
      <Stack.Navigator>{/* ... */}</Stack.Navigator>
    </NavigationContainer>
  );
}

Upgrading from 4.x

Any reason not to keep this current?

@lesmo lesmo self-assigned this May 20, 2021
@lesmo lesmo added enhancement New feature or request good first issue Good for newcomers labels May 20, 2021
@lesmo
Copy link

lesmo commented May 20, 2021

Yeah I totally agree.. I believe at the time I built this the react-navigation lib was in beta. I'll try to update the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants